Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

115 issues with dft xc extraction #119

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

ndaelman-hu
Copy link
Collaborator

Fix reported issues of the libxc name normalization

@ndaelman-hu ndaelman-hu added the bug Something isn't working label Sep 16, 2024
@ndaelman-hu ndaelman-hu self-assigned this Sep 16, 2024
@JosePizarro3 JosePizarro3 merged commit 8cf4685 into develop Sep 17, 2024
7 checks passed
@JosePizarro3 JosePizarro3 deleted the 115-issues-with-dft-xc-extraction branch September 17, 2024 06:39
@ndaelman-hu
Copy link
Collaborator Author

Thank you for reviewing and approving. In the future, pls leave the merging to the assignee, though. When this got merged, it has my name on it, i.e. it's as if I sign off on it. As with official documents, one doesn't forge signatures, either. Similarly, for deleting active branches.

In this case, there's little harm (and I don't have to revert develop), as the fix to 1 was already completed and stands separately from issue 2. I was just waiting for a reply before fixing 2 and merging both together.
If the user needs one fix sooner, they / you can let me know, and we see to split the patches. Now, I actually don't know how urgent their issue 2 is.

@JosePizarro3
Copy link
Collaborator

Next time, please, be more verbose on what you have to do or not. But at least there is no harm, so no worries; just open a new pr if needed.

@ndaelman-hu
Copy link
Collaborator Author

Next time, please, be more verbose on what you have to do or not. But at least there is no harm, so no worries; just open a new pr if needed.

I'm always open to providing more information. Feel free to ask if something isn't clear.

@JosePizarro3
Copy link
Collaborator

Just add a todo with some list so we know if something is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants